Repository navigation
Automatically fetch Zenodo assets (profsea-assets) when initializing spatial components - #104
Merged
Merged
Conversation
Richard Anslow (richard17a)
requested a review
from Greg Munday (gregrmunday)
September 25, 2026 14:34
Greg Munday (gregrmunday)
approved these changes
Sep 25, 2026
Greg Munday (gregrmunday)
left a comment
Greg Munday (gregrmunday)
left a comment
Collaborator
There was a problem hiding this comment.
Looks great to me, nice one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the error outlined in issue #82.
Summary
Addresses a
FileNotFoundErrorraised when creating spatial components (e.g.GIA) before the required fingerprint assets have been downloaded.To avoid copying the
fetch_zenodo_fingerprintsmethod in each spatial component class, asset fetching has been moved into theSpatialComponentbase class (SpatialComponent.fetch_assets()).Added/updated tests to verify that the Zenodo assets are fetched when instantiating any of:
SpatialComponentGIAFingerprintSterodynamic